connectivity: introduce host firewall tests #2464
Conversation
viktor-kurchenko
force-pushed
the
pr/vk/host-firewall-tests
branch
from
55ce847 to
bcc9a07
Compare
No problem. Could you please just extend the commit message to link to the commit that originally introduced the tests and the one that dropped them, for the sake of traceability? Please also note that you'll also need to initialize the |
viktor-kurchenko
force-pushed
the
pr/vk/host-firewall-tests
branch
from
bcc9a07 to
e6d2fce
Compare
Done, sorry again! |
|
hello @viktor-kurchenko , we are in the process of moving the connectivity package from cilium-cli to cilium repo. there are 2 pending pull requests:
once these 2 pull requests are merged, you need to open a pull request in cilium/cilium repository instead. sorry for the inconvenience! a cilium slack thread in #testing channel: https://cilium.slack.com/archives/C7PE7V806/p1711552887006539 |
Gotcha! Will do, thanks! |
|
the connectivity package came back to cilium-cli repo: #2477 you can re-open this pull request 🚀🙏 |
|
could you rebase to get rid of |
michi-covalent
added
the
needs-rebase
Introduce two new tests covering the host firewall functionality, i.e., asserting that both ingress and egress CiliumClusterwideNetworkPolicies specifying a NodeSelector correctly block the expected traffic. The tests are executed only when the unsafe tests are enabled, as potentially disruptive if executed against a live cluster. Original commit by Marco Iorio 7a928d6 has been accidentally dropped by the following commit during merge 486eb99 Signed-off-by: viktor-kurchenko <[email protected]>
viktor-kurchenko
force-pushed
the
pr/vk/host-firewall-tests
branch
from
e6d2fce to
627653b
Compare
Done, thanks! |
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
Sweet! Maybe we can get rid of https://github.com/cilium/cilium/blob/main/test/k8s/datapath_configuration.go#L574 once the CLI test is being in use by cilium/cilium? |
AFAICT, the main missing part would be the host-to-host coverage, which seems to be included in the Ginkgo tests. |
Introduce two new tests covering the host firewall functionality, i.e., asserting that both ingress and egress CiliumClusterwideNetworkPolicies specifying a NodeSelector correctly block the expected traffic. The tests are executed only when the unsafe tests are enabled, as potentially disruptive if executed against a live cluster.
Original commit by Marco Iorio
7a928d6
has been accidentally dropped by the following commit during merge
486eb99